Open
Conversation
Author
|
Unfortunately, I couldn't wait until this was merged, so I made another one. If you are having the same issue check the alternative version here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR will make it easier to get a payment token and a payment URL for the same payment order.
What is the current behavior? (You can also link to an open issue here)
The current behavior makes it impossible to generate a payment URL and get a token simultaneously without re-implementing the URL generation part.
This doesn't make it maintainable if YCP decides to change something in how URLs are composed.
What is the new behavior (if this is a feature change)?
The token and URL generation are separated into different methods while keeping BC and introducing a new method that can generate the Payment URL from the fetched token
Other information: